Skip to content
This repository has been archived by the owner on Nov 27, 2019. It is now read-only.

test: remove warnings about quoted keywords #29

Merged
merged 1 commit into from Nov 23, 2018
Merged

test: remove warnings about quoted keywords #29

merged 1 commit into from Nov 23, 2018

Conversation

Highjhacker
Copy link
Contributor

Proposed changes

Fixed the tests to remove the warning while running in. Nothing critical, but it remove a lot of useless output. The warnings were caused by the double quotes like here :

json(%{"success" => true, "data" => %{ "synced": true }})

Which threw these warnings :

but the quotes are not required. Note that keywords are always atoms, even when quoted, and quotes should only be used to introduce keywords with foreign characters in them

Types of changes

  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@codecov-io
Copy link

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   65.73%   65.73%           
=======================================
  Files          18       18           
  Lines         143      143           
=======================================
  Hits           94       94           
  Misses         49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898992d...7a298ab. Read the comment docs.

@faustbrian faustbrian changed the title Fixed tests test: remove warnings about quoted keywords Nov 23, 2018
@faustbrian faustbrian merged commit 2393bd8 into ArkEcosystemArchive:master Nov 23, 2018
@faustbrian
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants