Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in locks #66

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@dated
Copy link
Contributor

dated commented Nov 3, 2019

Summary

Fixes some typos merged with #64.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@dated dated requested review from faustbrian and supaiku0 as code owners Nov 3, 2019
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Nov 3, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 3, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (develop@c597fe7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #66   +/-   ##
==========================================
  Coverage           ?   59.16%           
==========================================
  Files              ?       15           
  Lines              ?      120           
  Branches           ?        0           
==========================================
  Hits               ?       71           
  Misses             ?       49           
  Partials           ?        0
Impacted Files Coverage Δ
lib/arkecosystem/client/api/locks.ex 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c597fe7...2be21ad. Read the comment docs.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Nov 4, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 98e7007 into ArkEcosystem:develop Nov 4, 2019
2 checks passed
2 checks passed
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Nov 4, 2019

Your pull request has been merged. Thank you for your contribution to the ARK Ecosystem.

@dated dated deleted the dated:patch-1 branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.