Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use blockId schema #10

Merged
merged 6 commits into from May 23, 2019

Conversation

@supaiku0
Copy link
Contributor

commented May 21, 2019

Summary

Use @arkecosystem/crypto for validating the schemas.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
faustbrian and others added 2 commits May 22, 2019

@supaiku0 supaiku0 marked this pull request as ready for review May 22, 2019

@supaiku0 supaiku0 requested a review from faustbrian as a code owner May 22, 2019

@supaiku0 supaiku0 force-pushed the supaiku0:refactpr-blockid-schema branch from 02e5463 to c4a4444 May 23, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 23, 2019

The ci/circleci: node-11 job is failing as of 2ca5ec352a59b83a3fdaaaf0e0a9394050216c46. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 23, 2019

The ci/circleci: node-10 job is failing as of c4a4444b3d34d761e89e8649b08b69f0aed8ed18. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

supaiku0 and others added 2 commits May 23, 2019
@codecov-io

This comment has been minimized.

Copy link

commented May 23, 2019

Codecov Report

Merging #10 into master will decrease coverage by 0.65%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   93.29%   92.63%   -0.66%     
==========================================
  Files           6        6              
  Lines         164      163       -1     
  Branches       22       22              
==========================================
- Hits          153      151       -2     
- Misses         11       12       +1
Impacted Files Coverage Δ
src/server/methods.ts 97.01% <ø> (ø) ⬆️
src/server/index.ts 84% <100%> (-4.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0355ab2...2ca5ec3. Read the comment docs.

@faustbrian faustbrian merged commit 993a9d9 into ArkEcosystem:master May 23, 2019

2 checks passed

ci/circleci: node-10 Your tests passed on CircleCI!
Details
ci/circleci: node-11 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.