Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use ports returned via API and fallback to seeds #19

merged 4 commits into from Jun 11, 2019


None yet
4 participants
Copy link

commented Jun 10, 2019

Make use of the new ports property in Core 2.4.0 to detect the API port instead of hardcoding it and add a fallback to seeds if no peers are found.

Resolves #18

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

This comment has been minimized.

Copy link

commented Jun 10, 2019

Codecov Report

Merging #19 into master will decrease coverage by 0.34%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
- Coverage   91.66%   91.32%   -0.35%     
  Files           6        6              
  Lines         180      196      +16     
  Branches       23       27       +4     
+ Hits          165      179      +14     
- Misses         15       17       +2
Impacted Files Coverage Δ
packages/rpc/src/server/index.ts 90.9% <100%> (ø) ⬆️
packages/rpc/src/services/network.ts 87.03% <88.88%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 088dd21...19fa4fa. Read the comment docs.


This comment has been minimized.

Copy link

commented Jun 10, 2019

The ci/circleci: node-10 job is failing as of 19fa4fa03705be62c5db0f6b55d0a10e8115a9dc. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian merged commit 54c5a1e into master Jun 11, 2019

3 checks passed

ci/circleci: node-10 Your tests passed on CircleCI!
ci/circleci: node-11 Your tests passed on CircleCI!
ci/circleci: node-12 Your tests passed on CircleCI!

@ArkEcosystemBot ArkEcosystemBot deleted the feat/custom-ports branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.