Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix failing and update workflow #54

Merged
merged 4 commits into from Nov 8, 2019

Conversation

@dated
Copy link
Contributor

dated commented Nov 8, 2019

Summary

Fixes a failing test and updates the github actions workflow, dropping node 10 and fixing the branch matchers.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
dated added 2 commits Nov 8, 2019
@dated dated requested review from faustbrian and supaiku0 as code owners Nov 8, 2019
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Nov 8, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

dated added 2 commits Nov 8, 2019
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Nov 8, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 2787cf1 into ArkEcosystem:master Nov 8, 2019
5 checks passed
5 checks passed
unit (12.x)
Details
codeclimate All good!
Details
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/rpc/package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Nov 8, 2019

Your pull request has been merged. Thank you for your contribution to the ARK Ecosystem.

@dated dated deleted the dated:test/wallets branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.