Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vote and delegate registration creation #81

Merged
merged 6 commits into from Feb 3, 2020
Merged

Conversation

@faustbrian
Copy link
Contributor

faustbrian commented Feb 3, 2020

Summary

Adds support for creating votes and delegate registration through the JSON-RPC. The voting and unvoting process has been split into 2 endpoints to abstract the -/+ oddity in the design of the transaction type.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #81 into master will decrease coverage by 1.15%.
The diff coverage is 86.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   89.84%   88.69%   -1.16%     
==========================================
  Files           6        7       +1     
  Lines         197      230      +33     
  Branches       28       28              
==========================================
+ Hits          177      204      +27     
- Misses         19       25       +6     
  Partials        1        1
Impacted Files Coverage Δ
packages/rpc/src/utils/crypto.ts 100% <100%> (ø)
packages/rpc/src/server/methods.ts 91.11% <79.16%> (-4.55%) ⬇️
packages/rpc/src/utils/transactions.ts 86.84% <86.84%> (ø)
packages/rpc/src/services/logger.ts 66.66% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f53a87...a879c29. Read the comment docs.

Copy link
Member

ItsANameToo left a comment

Will test it in a minute :bleh:

packages/rpc/__tests__/server/transactions.test.ts Outdated Show resolved Hide resolved
packages/rpc/__tests__/server/transactions.test.ts Outdated Show resolved Hide resolved
packages/rpc/__tests__/server/transactions.test.ts Outdated Show resolved Hide resolved
faustbrian and others added 5 commits Feb 3, 2020
Co-Authored-By: ItsANameToo <35610748+ItsANameToo@users.noreply.github.com>
Co-Authored-By: ItsANameToo <35610748+ItsANameToo@users.noreply.github.com>
Co-Authored-By: ItsANameToo <35610748+ItsANameToo@users.noreply.github.com>
@faustbrian faustbrian merged commit 2ad2302 into master Feb 3, 2020
4 of 7 checks passed
4 of 7 checks passed
unit (12.x)
Details
codeclimate 9 issues to fix
Details
codecov/patch 86.11% of diff hit (target 89.84%)
Details
codecov/project 88.69% (-1.16%) compared to 4f53a87
Details
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/rpc/package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot ArkEcosystemBot deleted the vote-delegate branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.