Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre aip11 compatibility #82

Merged
merged 2 commits into from Feb 4, 2020
Merged

Conversation

@ItsANameToo
Copy link
Member

ItsANameToo commented Feb 4, 2020

Adds a check for aip11 and sets a nonce if the milestone is reached. Uses a setTimeout to check every blocktime seconds for the new height. Once the aip11 height is reached, no new call is made

Tested it on mainnet and it could send a transaction: https://explorer.ark.io/transaction/d17782caa59c92ece2c6e7dc9fecff7c884508e8186ab77a6ce2827375c0a0ea

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #82 into master will increase coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   88.69%   89.87%   +1.17%     
==========================================
  Files           7        7              
  Lines         230      237       +7     
  Branches       28       30       +2     
==========================================
+ Hits          204      213       +9     
+ Misses         25       23       -2     
  Partials        1        1              
Impacted Files Coverage Δ
packages/rpc/src/utils/transactions.ts 95.00% <0.00%> (+8.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821f1d2...8f1baa7. Read the comment docs.

@faustbrian faustbrian merged commit 267cc3e into master Feb 4, 2020
6 of 7 checks passed
6 of 7 checks passed
unit (12.x)
Details
codecov/patch 87.50% of diff hit (target 88.69%)
Details
codeclimate All good!
Details
codecov/project 89.87% (+1.17%) compared to 821f1d2
Details
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/rpc/package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot ArkEcosystemBot deleted the feat/pre-aip11-compatibility branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.