New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong transactions being shown for a wallet #180

Merged
merged 2 commits into from May 13, 2018

Conversation

Projects
None yet
2 participants
@ItsANameToo
Copy link
Contributor

ItsANameToo commented May 13, 2018

Sometimes when navigating to a wallet, it would briefly show the transactions of the wallet and then replace them with the latest transactions (as on the home page). This PR adds a check for an undefined wallet param, so it will no longer show those wrong transactions.

Steps to reproduce the issue:

  1. go to the explorer
  2. click on an entry in the transactions table
  3. wallet should load up with the right transactions
  4. from this wallet, click on another recipient so you navigate to another wallet
  5. this wallet should briefly show the right transactions, after which they get replaced with the latest transactions from the home page (if not: repeat step 4 :P)

@faustbrian faustbrian merged commit b2a135d into ArkEcosystem:master May 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ItsANameToo ItsANameToo deleted the ItsANameToo:fix-wrong-transactions-wallet branch May 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment