New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds missing transaction types to link-wallet component #226

Merged
merged 2 commits into from May 31, 2018

Conversation

Projects
None yet
4 participants
@dated
Copy link
Contributor

dated commented May 30, 2018

as can be seen here for example, some transaction types were not considered in the link-wallet component, leaving the "recipient" field empty. the missing transaction types were added.

these are mostly placeholders, transaction type 4 is the only new one for which there actually are transactions.

if someone who speaks dutch wants to confirm the durch translations that be great :)

@ItsANameToo
Copy link
Contributor

ItsANameToo left a comment

Dutch looks good, just one change needed :)

"IPFS": "IPFS",
"Timelock Transfer": "Timelock Transfer",
"Multipayment": "Multipayment",
"Delegate Resignation": "Ontslag Afgevaardigde"

This comment has been minimized.

@ItsANameToo

ItsANameToo May 30, 2018

Contributor

Would be better to make it "Aftreden Afgevaardigde"

@axenter
Copy link

axenter left a comment

Blijft toch gek klinken in het NL, (still sounds funny in dutch ) but yes agreed that should be it

@dated

This comment has been minimized.

Copy link
Contributor Author

dated commented May 30, 2018

Thanks! I'll change it asap

@faustbrian faustbrian merged commit 4d72bcc into ArkEcosystem:master May 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dated dated deleted the dated:transaction-types branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment