Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: have detail grids handle borders #366

Merged

Conversation

Highjhacker
Copy link
Contributor

Summary

https://app.clickup.com/t/9rx4g6

Fix the issue without-border brought where the last and before last elements were missing a border between each, now will show borders properly depending on the screen resolution.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link
Member

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to handle this in the grids with css instead of passing a property as you're pretty much caring about the border only (so both responsive-border and without-border depend on whatever entry is last and can be achieved with css, without having to update references when another item gets added to the grid)

@ItsANameToo ItsANameToo changed the title fix: transaction details page - add border back before last element refactor: have detail grids handle borders Nov 2, 2020
@faustbrian faustbrian merged commit ca8049f into develop Nov 2, 2020
@faustbrian faustbrian deleted the fix/transaction-details-page-smartbridge-nonce-borders branch November 2, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants