New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow transactions filtering by types #513

Merged
merged 15 commits into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@Highjhacker
Copy link
Contributor

Highjhacker commented Dec 22, 2018

Proposed changes

I think a dropdown allowing the tx types filter on the homepage would be nice.

Alt Text

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Highjhacker Highjhacker changed the title [WIP DO NOT MERGE] feat: Allow transactions filtering by types feat: Allow transactions filtering by types Dec 24, 2018

Highjhacker and others added some commits Dec 24, 2018

@faustbrian

This comment has been minimized.

Copy link
Contributor

faustbrian commented Dec 30, 2018

As this is a new feature you will need to add tests.

faustbrian and others added some commits Dec 30, 2018

removed the image from the Transactions page and added the Transactio…
…ns title to that same page. Added tests for transactions services and transactions page
removed the image from the Transactions page and added the Transactio…
…ns title to that same page. Added tests for transactions services and transactions page

Highjhacker added some commits Dec 30, 2018

@faustbrian faustbrian merged commit e1d67ee into ArkEcosystem:master Jan 3, 2019

0 of 2 checks passed

ci/circleci: test-node-9 Your tests failed on CircleCI
Details
ci/circleci: test-node-stable Your tests failed on CircleCI
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment