New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reset the headerType to null (default) when clicking outside search bar #516

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@JeremiGendron
Copy link
Contributor

JeremiGendron commented Dec 24, 2018

Fixes #517

Proposed changes

It didn't feel intuitive that the header didn't reset to show more relevant options when I wanted to "cancel" a search by clicking outside of the search bar.

  • Add and register the click-outside directive
  • Implement click-outside with simple closeHeader() function in Header/Main.vue -> methods

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
feat(header): Reset the headerType to null (default) when clicking ou…
…tside of search bar

It was annoying to not have the header reset when clicking outside of the search bar.

@faustbrian faustbrian merged commit af707cb into ArkEcosystem:master Jan 3, 2019

0 of 2 checks passed

ci/circleci: test-node-9 Your tests failed on CircleCI
Details
ci/circleci: test-node-stable Your tests failed on CircleCI
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment