New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented transactions filter on the homepage #535

Merged
merged 6 commits into from Jan 8, 2019

Conversation

Projects
None yet
4 participants
@Highjhacker
Copy link
Contributor

Highjhacker commented Jan 3, 2019

Proposed changes

New feature similar to the one I recently pushed. This one allow to filter the transactions from the homepage of the explorer and will set the choice of the user in the localStorage, that way if user click on "Show more" he will continue to see the filter type he chosed, and vice versa from the transactions page to the homepage. Also added tests for that new feature. Also added the 'Transfer' translation key who were missing.

Note : The filtering on the homepage is quite slow, take a few seconds, so maybe something not done properly on my side, let me know and I will correct.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Highjhacker and others added some commits Jan 3, 2019

feat: Implemented transactions filter on the homepage. Also added tes…
…ts for that new feature. Also added the Transfer translation key who was missing
Show resolved Hide resolved test/e2e/specs/homepage.js

Highjhacker and others added some commits Jan 7, 2019

@faustbrian faustbrian merged commit 0210c90 into ArkEcosystem:master Jan 8, 2019

2 checks passed

ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-stable Your tests passed on CircleCI!
Details
@dated

This comment has been minimized.

Copy link
Contributor

dated commented Jan 8, 2019

if you don't mind I'll change the design of that on the landing page @Highjhacker, doesn't look too good imho.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment