New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: display default token while waiting for network token #538

Merged
merged 3 commits into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@dated
Copy link
Contributor

dated commented Jan 4, 2019

Proposed changes

Similar to #501, this adds a fallback value for the network token while it is being fetched.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
Show resolved Hide resolved package.json Outdated

@faustbrian faustbrian merged commit 5e862c9 into ArkEcosystem:master Jan 4, 2019

2 checks passed

ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-stable Your tests passed on CircleCI!
Details

@dated dated deleted the dated:network-token branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment