New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cast type to integer so it properly filters "all" #539

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
4 participants
@ItsANameToo
Copy link
Contributor

ItsANameToo commented Jan 4, 2019

Proposed changes

Fixes the transactions no longer being loaded if you set the transaction type to All.

How to reproduce the current issue:

  1. Go to https://explorer.ark.io
  2. Click 'show more'
  3. Set filter type to 'All' (or to 'Vote' first and then back to 'All')
  4. Go back to homepage
  5. Click on 'show more' again and the console will show an error and you will not navigate to the transaction page

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 4, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@5e862c9). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #539   +/-   ##
=========================================
  Coverage          ?   47.08%           
=========================================
  Files             ?       83           
  Lines             ?     1457           
  Branches          ?      181           
=========================================
  Hits              ?      686           
  Misses            ?      761           
  Partials          ?       10
Impacted Files Coverage Δ
src/pages/Transactions.vue 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e862c9...ade1b77. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 4, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@5e862c9). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #539   +/-   ##
=========================================
  Coverage          ?   47.08%           
=========================================
  Files             ?       83           
  Lines             ?     1457           
  Branches          ?      181           
=========================================
  Hits              ?      686           
  Misses            ?      761           
  Partials          ?       10
Impacted Files Coverage Δ
src/pages/Transactions.vue 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e862c9...ade1b77. Read the comment docs.

@dated

dated approved these changes Jan 7, 2019

@faustbrian faustbrian merged commit bdd2be6 into ArkEcosystem:master Jan 7, 2019

2 checks passed

ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-stable Your tests passed on CircleCI!
Details

@ItsANameToo ItsANameToo deleted the ItsANameToo:fix/tx-sorting branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment