New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: transaction filtering #542

Merged
merged 12 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@dated
Copy link
Contributor

dated commented Jan 8, 2019

Proposed changes

Redesigns as shown in #541 and refactors/fixes the logic of the transaction filtering on the homepage.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

dated added some commits Jan 8, 2019

@dated dated changed the title refactor: transaction filtering [WIP] refactor: transaction filtering Jan 8, 2019

@zillionn

This comment has been minimized.

Copy link
Contributor

zillionn commented Jan 8, 2019

Haven't looked into your code, but how do you order the txs? I believe currently they're ordered only by timestamp and if they have the same timestamp they rearrange everytime I scroll.

@dated

This comment has been minimized.

Copy link
Contributor

dated commented Jan 8, 2019

Imho the API should take care of the correct ordering - and ordering by timestamp does not work correctly there at the moment (ordering by timestamp does return a list that is out of order).

dated added some commits Jan 8, 2019

@dated dated force-pushed the dated:transaction-filtering branch from f183e64 to 5ee688e Jan 9, 2019

@dated

This comment has been minimized.

Copy link
Contributor

dated commented Jan 9, 2019

Timestamp based sorting should be fixed with ArkEcosystem/core#1957

@dated dated force-pushed the dated:transaction-filtering branch from 04fa9ea to f5d920f Jan 9, 2019

@dated dated force-pushed the dated:transaction-filtering branch 2 times, most recently from f34c2e0 to 9e0f9fc Jan 9, 2019

@dated dated force-pushed the dated:transaction-filtering branch from 9e0f9fc to 9a51979 Jan 9, 2019

@dated dated changed the title [WIP] refactor: transaction filtering refactor: transaction filtering Jan 9, 2019

@dated dated changed the title refactor: transaction filtering refactor/fix: transaction filtering Jan 9, 2019

dated added some commits Jan 9, 2019

@dated dated force-pushed the dated:transaction-filtering branch from 26925e4 to 0242579 Jan 9, 2019

@faustbrian faustbrian changed the title refactor/fix: transaction filtering refactor: transaction filtering Jan 10, 2019

@faustbrian faustbrian merged commit b45b3fe into ArkEcosystem:master Jan 10, 2019

2 checks passed

ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-stable Your tests passed on CircleCI!
Details

@dated dated deleted the dated:transaction-filtering branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment