Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add node.js 12 to CircleCI #630

merged 2 commits into from May 27, 2019


Copy link

commented May 27, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build-related change
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:


This comment has been minimized.

Copy link

commented May 27, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.


This comment has been minimized.

Copy link

commented May 27, 2019

The ci/circleci: test-node-11 job is failing as of e49f902b744473e2a075c4c272e0eff9f4e1219e. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!


This comment has been minimized.

Copy link

commented May 27, 2019

Codecov Report

Merging #630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #630   +/-   ##
  Coverage   44.17%   44.17%           
  Files          90       90           
  Lines        1589     1589           
  Branches      177      223   +46     
  Hits          702      702           
  Misses        882      882           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8afb4...e49f902. Read the comment docs.

@ItsANameToo ItsANameToo merged commit e0159d3 into master May 27, 2019

3 checks passed

ci/circleci: test-node-10 Your tests passed on CircleCI!
ci/circleci: test-node-11 Your tests passed on CircleCI!
ci/circleci: test-node-12 Your tests passed on CircleCI!

@ArkEcosystemBot ArkEcosystemBot deleted the node-12 branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.