Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show progress bar on route change #714

Merged
merged 2 commits into from Aug 23, 2019

Conversation

@dated
Copy link
Contributor

commented Aug 22, 2019

Adds the vue-nprogress package so that a progress bar is shown at the top of the page on route changes.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ItsANameToo

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

codacy hurry up 😠

@ItsANameToo ItsANameToo merged commit fb3bc5e into ArkEcosystem:develop Aug 23, 2019
2 checks passed
2 checks passed
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-12 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the dated:feat/progress-bar branch Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.