New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch body and queryString parameters inside the create method #39

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@Highjhacker
Copy link
Contributor

Highjhacker commented Jan 2, 2019

Proposed changes

Had to switch these two parameters, creation of a transaction wasn't working because of that.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   60.75%   60.75%           
=======================================
  Files           9        9           
  Lines         293      293           
=======================================
  Hits          178      178           
  Misses         73       73           
  Partials       42       42
Impacted Files Coverage Δ
client/transactions.go 59.09% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9784179...f1c5707. Read the comment docs.

@faustbrian faustbrian merged commit 3f94b23 into ArkEcosystem:master Jan 3, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment