New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from uint16 to uint32 #41

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
3 participants
@KaiserKarel
Copy link
Contributor

KaiserKarel commented Jan 6, 2019

When a large number of pages remains, PageCount and possibly count and totalcount overflow. Increasing the size to uint32 should prevent these errors.

Proposed changes

#40

Types of changes

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • [X ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • [X ] I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
move from uint16 to uint32
When a large number of pages remains, PageCount and possibly count and totalcount overflow. Increasing the size to uint32 should prevent these errors.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   60.75%   60.75%           
=======================================
  Files           9        9           
  Lines         293      293           
=======================================
  Hits          178      178           
  Misses         73       73           
  Partials       42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f94b23...b89cc13. Read the comment docs.

@faustbrian faustbrian merged commit b8a6e1b into ArkEcosystem:master Jan 8, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
@faustbrian

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment