Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node/fees endpoint #47

Merged
merged 2 commits into from May 12, 2019

Conversation

Projects
None yet
3 participants
@dated
Copy link
Contributor

commented May 10, 2019

Proposed changes

Adds the new node/fees API endpoint.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

This also adjusts the expected data types to those we see on devnet currently.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2019

I just noticed the spacing issues, those will be fixed in due time. In Go you prefer tabs over spaces, is that correct @faustbrian?

@faustbrian

This comment has been minimized.

Copy link
Contributor

commented May 11, 2019

Tabs are the standard in golang, you can go check the gofmt docs.

@dated dated force-pushed the dated:feat/fees-endpoint branch from 8d402d3 to 1acb335 May 11, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 12, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 6c8a1ce into ArkEcosystem:develop May 12, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 12, 2019

Your pull request has been merged and marked as tier 4. It will earn you $10 USD.

@ArkEcosystem ArkEcosystem deleted a comment from ArkEcosystemBot May 12, 2019

@dated dated deleted the dated:feat/fees-endpoint branch May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.