From f40d20d484fa6ed5c78fa1cbdef687d1626d3776 Mon Sep 17 00:00:00 2001 From: Brian Faust Date: Tue, 11 Dec 2018 13:17:03 +0200 Subject: [PATCH 1/4] chore: remove the wrapper task to get up CircleCI --- build.gradle | 4 ---- 1 file changed, 4 deletions(-) diff --git a/build.gradle b/build.gradle index e51cd0f7..bf0f4b12 100644 --- a/build.gradle +++ b/build.gradle @@ -116,7 +116,3 @@ jacocoTestReport { html.enabled false } } - -task wrapper(type: Wrapper) { - gradleVersion = '4.9' -} From 2c34e1a4a00143e851b6044c6cf5978e24243f66 Mon Sep 17 00:00:00 2001 From: Brian Faust Date: Tue, 11 Dec 2018 13:21:42 +0200 Subject: [PATCH 2/4] chore: replace wrapper task with wrapper config --- build.gradle | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/build.gradle b/build.gradle index bf0f4b12..c5dddfc9 100644 --- a/build.gradle +++ b/build.gradle @@ -116,3 +116,7 @@ jacocoTestReport { html.enabled false } } + +wrapper { + gradleVersion = '4.9' +} From a6bb68c2b2fb695e263b0d1ef28db8b633af1a95 Mon Sep 17 00:00:00 2001 From: Brian Faust Date: Tue, 11 Dec 2018 13:28:01 +0200 Subject: [PATCH 3/4] test: assert correct devnet version --- src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java b/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java index 05f280de..523a9b5b 100644 --- a/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java +++ b/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java @@ -9,7 +9,7 @@ class DevnetTest { @Test void version() { - assertEquals(0x17, Network.get().version()); + assertEquals(0x1E, Network.get().version()); } @Test From 914602ee7a88516d1e8a9c85b731e3e8e7aab7e1 Mon Sep 17 00:00:00 2001 From: Brian Faust Date: Tue, 11 Dec 2018 13:30:18 +0200 Subject: [PATCH 4/4] test: use devnet to make the assertions for the devnet test --- .../java/org/arkecosystem/crypto/networks/DevnetTest.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java b/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java index 523a9b5b..2e654f14 100644 --- a/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java +++ b/src/test/java/org/arkecosystem/crypto/networks/DevnetTest.java @@ -1,6 +1,5 @@ package org.arkecosystem.crypto.networks; -import org.arkecosystem.crypto.configuration.Network; import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; @@ -9,16 +8,16 @@ class DevnetTest { @Test void version() { - assertEquals(0x1E, Network.get().version()); + assertEquals(0x1E, new Devnet().version()); } @Test void wif() { - assertEquals(170, Network.get().wif()); + assertEquals(170, new Devnet().wif()); } @Test void epoch() { - assertEquals("2017-03-21 13:00:00", Network.get().epoch()); + assertEquals("2017-03-21 13:00:00", new Devnet().epoch()); } }