Skip to content

Conversation

@spkjp
Copy link
Contributor

@spkjp spkjp commented Jul 8, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Jul 8, 2019
@ghost
Copy link

ghost commented Jul 8, 2019

The ci/circleci: build job is failing as of 92e70550a5543c7d3a610f59737c9227cd8e8fa0. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian merged commit 1f449da into master Jul 9, 2019
@ghost ghost deleted the chore/deps branch July 9, 2019 02:09
spkjp pushed a commit that referenced this pull request Oct 10, 2019
* release: 0.1.4 (#47)

* chore: bump dependencies (#49)

* release: 0.1.5 (#50)

* chore: downgrade bitcoinj-core to 0.14.7 (#51)

* release: 0.1.6 (#52)

* chore: setup probot/stale configuration

* chore(readme): add lead maintainer information (#54)

* ci: setup github action workflow for testing

* ci: adjust job triggers (#58)

* ci: report coverage to codecov (#59)

* chore(deps): add renovate.json (#60)

* chore(deps): update dependency gradle to v5
spkjp added a commit that referenced this pull request Jan 17, 2020
* release: 0.1.4 (#47)

* chore: bump dependencies (#49)

* release: 0.1.5 (#50)

* chore: downgrade bitcoinj-core to 0.14.7 (#51)

* release: 0.1.6 (#52)

* chore: setup probot/stale configuration

* chore(readme): add lead maintainer information (#54)

* ci: setup github action workflow for testing

* ci: adjust job triggers (#58)

* ci: report coverage to codecov (#59)

* chore(deps): add renovate.json (#60)

* chore: update workflow config (#66)

* chore(deps): update dependency gradle to v6 (#70)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency com.google.code.gson:gson to v2.8.6 (#71)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency org.bitcoinj:bitcoinj-core to v0.15.6 (#72)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency org.bouncycastle:bcprov-jdk15on to v1.64 (#73)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* fix: handle SignatureDecodeException (#85)

* fix: handle SignatureDecodeException

* fix: exception handling in Message.java re: update bitcoinj

* fix: remove bouncy castle from deps // collision with bitcoinj

* chore: update guava package

* style: spotless

* style: spotless included now in test folder to

* chore(deps): update dependency gradle to v6.1.0 (#87)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(test): added actions for different java versions

* Revert "chore(test): added actions for different java versions"

This reverts commit 71db89a.

* chore: add actions for different JDK versions (#90)

Co-authored-by: supaiku <1311798+supaiku0@users.noreply.github.com>
Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edgar Goetzendorff <hello@dated.fun>
Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
kristjank pushed a commit that referenced this pull request Feb 10, 2020
* release: 0.1.4 (#47)

* chore: bump dependencies (#49)

* release: 0.1.5 (#50)

* chore: downgrade bitcoinj-core to 0.14.7 (#51)

* release: 0.1.6 (#52)

* chore: setup probot/stale configuration

* chore(readme): add lead maintainer information (#54)

* ci: setup github action workflow for testing

* ci: adjust job triggers (#58)

* ci: report coverage to codecov (#59)

* chore(deps): add renovate.json (#60)

* chore: update workflow config (#66)

* chore(deps): update dependency gradle to v6 (#70)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency com.google.code.gson:gson to v2.8.6 (#71)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency org.bitcoinj:bitcoinj-core to v0.15.6 (#72)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency org.bouncycastle:bcprov-jdk15on to v1.64 (#73)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* fix: handle SignatureDecodeException (#85)

* fix: handle SignatureDecodeException

* fix: exception handling in Message.java re: update bitcoinj

* fix: remove bouncy castle from deps // collision with bitcoinj

* chore: update guava package

* chore(deps): update dependency gradle to v6.1.0 (#87)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore: add actions for different JDK versions (#90)

* chore(deps): update dependency org.junit.jupiter:junit-jupiter-api to v5.6.0 (#93)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency org.junit.jupiter:junit-jupiter-engine to v5.6.0 (#94)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency gradle to v6.1.1 (#95)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
Co-authored-by: Kristjan Kosic <chris@ark.io>

* style: spotless apply

Co-authored-by: supaiku <1311798+supaiku0@users.noreply.github.com>
Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edgar Goetzendorff <hello@dated.fun>
Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
kristjank pushed a commit that referenced this pull request Feb 12, 2020
* feat: add AIP11 transaction types (#56)

* chore(deps): update dependency gradle to v5 (#62)

* release: 0.1.4 (#47)

* chore: bump dependencies (#49)

* release: 0.1.5 (#50)

* chore: downgrade bitcoinj-core to 0.14.7 (#51)

* release: 0.1.6 (#52)

* chore: setup probot/stale configuration

* chore(readme): add lead maintainer information (#54)

* ci: setup github action workflow for testing

* ci: adjust job triggers (#58)

* ci: report coverage to codecov (#59)

* chore(deps): add renovate.json (#60)

* chore(deps): update dependency gradle to v5

* refactor: add SpotlessPlugin and make required changes (#64)

* refactor: change transactionType in abstract builder into int (#68)

* chore: spotless plugin can only run with java 8 (#76)

* chore: remove throw statement if spotless is not run on java 8 (#78)

* style: rename AbstractTransaction to AbstractTransactionBuilder (#79)

* fix: enable vendorfield for multipayment (#81)

* fix: enable vendorfield for multipayment

* test: add vendorField to test multipayment txs

* chore: spotless plugin (#83)

Co-authored-by: Kristjan Kosic <chris@ark.io>

* chore: merge master into develop (#86)

* release: 0.1.4 (#47)

* chore: bump dependencies (#49)

* release: 0.1.5 (#50)

* chore: downgrade bitcoinj-core to 0.14.7 (#51)

* release: 0.1.6 (#52)

* chore: setup probot/stale configuration

* chore(readme): add lead maintainer information (#54)

* ci: setup github action workflow for testing

* ci: adjust job triggers (#58)

* ci: report coverage to codecov (#59)

* chore(deps): add renovate.json (#60)

* chore: update workflow config (#66)

* chore(deps): update dependency gradle to v6 (#70)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency com.google.code.gson:gson to v2.8.6 (#71)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency org.bitcoinj:bitcoinj-core to v0.15.6 (#72)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency org.bouncycastle:bcprov-jdk15on to v1.64 (#73)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* fix: handle SignatureDecodeException (#85)

* fix: handle SignatureDecodeException

* fix: exception handling in Message.java re: update bitcoinj

* fix: remove bouncy castle from deps // collision with bitcoinj

* chore: update guava package

* style: spotless

* style: spotless included now in test folder to

* chore(deps): update dependency gradle to v6.1.0 (#87)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(test): added actions for different java versions

* Revert "chore(test): added actions for different java versions"

This reverts commit 71db89a.

* chore: add actions for different JDK versions (#90)

Co-authored-by: supaiku <1311798+supaiku0@users.noreply.github.com>
Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edgar Goetzendorff <hello@dated.fun>
Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* Update HTLC claim to support secret of 32 bytes (#97)

* feat: added a task to build standalone jars (#99)

* fix: multipay serde fix and additional tests (#101)

* fix: toJson to accomodate for BigNums

* tests: additional helper tests

* fix: vendorField serialization

* lint: spotless

* test: new fixtures for ecdsa and fix for multipayment serde (#102)

* chore: .gitignore

* chore: .gitignore for idea

* fix: multipayment serde

* test: new generated fixtures (ecds)

* test: fixed test multipayment serde - use new fixtures

* test: fix transfer tests - migrate to new fixtures

* test: delegate registration to new fixures

* test: fix tests, move to new fixtures

* test: serde tests to new ecdsa fixtures

* test: moving to new fixtures

* fix: second signature registration serde methods (#103)

* style: spotless apply

* release: sync branches (#104)

* release: 0.1.4 (#47)

* chore: bump dependencies (#49)

* release: 0.1.5 (#50)

* chore: downgrade bitcoinj-core to 0.14.7 (#51)

* release: 0.1.6 (#52)

* chore: setup probot/stale configuration

* chore(readme): add lead maintainer information (#54)

* ci: setup github action workflow for testing

* ci: adjust job triggers (#58)

* ci: report coverage to codecov (#59)

* chore(deps): add renovate.json (#60)

* chore: update workflow config (#66)

* chore(deps): update dependency gradle to v6 (#70)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency com.google.code.gson:gson to v2.8.6 (#71)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency org.bitcoinj:bitcoinj-core to v0.15.6 (#72)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency org.bouncycastle:bcprov-jdk15on to v1.64 (#73)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* fix: handle SignatureDecodeException (#85)

* fix: handle SignatureDecodeException

* fix: exception handling in Message.java re: update bitcoinj

* fix: remove bouncy castle from deps // collision with bitcoinj

* chore: update guava package

* chore(deps): update dependency gradle to v6.1.0 (#87)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore: add actions for different JDK versions (#90)

* chore(deps): update dependency org.junit.jupiter:junit-jupiter-api to v5.6.0 (#93)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency org.junit.jupiter:junit-jupiter-engine to v5.6.0 (#94)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore(deps): update dependency gradle to v6.1.1 (#95)

Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
Co-authored-by: Kristjan Kosic <chris@ark.io>

* style: spotless apply

Co-authored-by: supaiku <1311798+supaiku0@users.noreply.github.com>
Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edgar Goetzendorff <hello@dated.fun>
Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>

* chore: changelog

* chore: pom version tag

Co-authored-by: KovacZan <39158639+KovacZan@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edgar Goetzendorff <hello@dated.fun>
Co-authored-by: supaiku <1311798+supaiku0@users.noreply.github.com>
Co-authored-by: Brian Faust <faustbrian@users.noreply.github.com>
Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants