Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #110

Merged
merged 3 commits into from May 12, 2019

Conversation

Projects
None yet
3 participants
@boveus
Copy link
Contributor

commented May 11, 2019

This PR adds the dependencies required for this package and adds the correct the yarn add command syntax.

I am not sure if the current version of Python is the correct one. I am getting an error when I try to install using that package. See: #111

Update README.md
Add dependencies, correct the yarn add command syntax

@boveus boveus requested review from faustbrian and supaiku0 as code owners May 11, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 11, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 11, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 11, 2019

The ci/circleci: test-node-9 job is failing as of b867744d0aa03ea9ce2850db9bdda6d9cf185842. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

1 similar comment
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 11, 2019

The ci/circleci: test-node-9 job is failing as of b867744d0aa03ea9ce2850db9bdda6d9cf185842. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian added some commits May 12, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 12, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit df6d480 into ArkEcosystem:master May 12, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 12, 2019

Your pull request has been merged and marked as tier 6. It will earn you $1 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.