New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue 25 - Crash if trying to send a transaction from a new account #37

Merged
merged 3 commits into from May 30, 2018

Conversation

Projects
None yet
2 participants
@wownmedia
Copy link
Contributor

wownmedia commented May 19, 2018

When a new account is created it is not directly know at all the nodes. When trying to send to/from this account using the postTransaction() method internally the getFromNode() method returns a failure status in the body of the response. There is no check for this status and subsequently the app will crash. This bug is described in issue #25.

I have fixed this bug by adding the necessary checks and error handling to the postTransaction() method.

I have spotted some other bugs in this file and will submit separate PRs for them later.

@faustbrian faustbrian merged commit e8ca065 into ArkEcosystem:master May 30, 2018

@wownmedia wownmedia deleted the wownmedia:fix-error-handling branch Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment