New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for USB init error on machines without USB port #41

Merged
merged 2 commits into from May 30, 2018

Conversation

Projects
None yet
2 participants
@wownmedia
Copy link
Contributor

wownmedia commented May 23, 2018

Fix for issue #40

Ark-client tries to initialize a USB port to check if a Ledger is connected, when no USB port can be initialized the app crashes.

I have added error handling for the loading of the modules that manage the Ledger. This prevents a crash when no USB port exists on the system. The user is warned when no support for the Ledger is available and all methods that might use the Ledger have an addtional check if Ledger support is enabled or not.

@faustbrian

This comment has been minimized.

Copy link
Contributor

faustbrian commented May 30, 2018

@wownmedia Please fix the conflicts, will merge this PR then.

@wownmedia

This comment has been minimized.

Copy link
Contributor Author

wownmedia commented May 30, 2018

Updated the code to remove the conflict.

@faustbrian faustbrian merged commit d7552a7 into ArkEcosystem:master May 30, 2018

@wownmedia wownmedia deleted the wownmedia:fix-USB-init-error-onserver-and-vm branch Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment