New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Generate and import passphrase in all possible bip39 languages #148

Merged
merged 2 commits into from May 19, 2018

Conversation

Projects
None yet
4 participants
@air1one
Copy link
Contributor

air1one commented Apr 17, 2018

This is a suggestion to allow to generate and import passphrase in any language (from the possible languages defined in bip39 wordlist).

I created a new option "Wordlist language" in Settings :
image
The language selected will be used to generate a new wallet (the passphrase will be in this language), and also for importing a wallet from passphrase (we will be able to enter the passphrase in this language).

For wallet import, entering a passphrase in english will still work, even if we select a different language in "Wordlist language". (we might want to generate wallets in a specific language but import a previous wallet which was generated in english)

Please tell me what do you think 馃槃

@alexbarnsley

This comment has been minimized.

Copy link
Member

alexbarnsley commented Apr 30, 2018

Thank you @air1one - I like the idea, but just getting some additional feedback internally so will get back to you either way 馃槃

@air1one

This comment has been minimized.

Copy link
Contributor Author

air1one commented May 3, 2018

OK no problem, looking forward to hear the team's feedback 馃憤

@alexbarnsley

This comment has been minimized.

Copy link
Member

alexbarnsley commented May 10, 2018

Hi @air1one, one of the guys tested and it doesn't seem backwards compatible with desktop wallet. We like the idea, but need to make sure it works and imports the same wallet on both desktop and mobile if that makes sense? 馃 Would you be able to implement the same in the v1 wallet (I know it's depreciated)? It currently things a different language phrase is not bip39 compatible

@air1one

This comment has been minimized.

Copy link
Contributor Author

air1one commented May 10, 2018

Ok yes I understand I will implement it in the desktop v1 wallet as well 馃憤 thanks

@air1one

This comment has been minimized.

Copy link
Contributor Author

air1one commented May 11, 2018

@air1one

This comment has been minimized.

Copy link
Contributor Author

air1one commented May 19, 2018

Updated the WORDLIST_LANGUAGE english translation following the discussion with @luciorubeens on ark-desktop that "Passphrase language" is clearer than "Wordlist language".

@luciorubeens luciorubeens merged commit 3cb3863 into ArkEcosystem:master May 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@luciorubeens

This comment has been minimized.

Copy link
Member

luciorubeens commented May 19, 2018

馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment