New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet import : allow the user to hide/show the passphrase while typing it #157

Merged
merged 2 commits into from May 30, 2018

Conversation

Projects
None yet
2 participants
@air1one
Copy link
Contributor

air1one commented May 16, 2018

Suggestion to improve security on wallet import, by allowing to hide the passphrase with a hide/show icon switch.

Hide mode would only display the word we are entering and hide all the other words, like this :
image

Main limitation in this mode :
We cannot edit directly the hidden words (the asterisks **), we can only edit the last visible word. (but would anybody want to edit directly the hidden part without seeing it ? 馃 )

Please tell me what you think 馃槂

@luciorubeens

This comment has been minimized.

Copy link
Member

luciorubeens commented May 22, 2018

Wow, I liked it! Can you fix these conflicts?

@air1one

This comment has been minimized.

Copy link
Contributor Author

air1one commented May 23, 2018

Yes @luciorubeens done !

@luciorubeens luciorubeens merged commit 22e70e0 into ArkEcosystem:master May 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@luciorubeens

This comment has been minimized.

Copy link
Member

luciorubeens commented May 30, 2018

Sorry my late reply, thank you! 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment