Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Bug: Fix delegate search #225

Merged
merged 7 commits into from Oct 30, 2018
Merged

Bug: Fix delegate search #225

merged 7 commits into from Oct 30, 2018

Conversation

kalgoop
Copy link
Contributor

@kalgoop kalgoop commented Oct 28, 2018

filterBy pipe of ngx-filter wasn't filtering the list, in the previous version.

Now, used ngFor with ngIf to filter according to searchQuery.username

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

filterBy pipe of ngx-filter wasn't filtering the list, in the previous version.

Now, used ngFor with ngIf to filter according to searchQuery.username
@kalgoop
Copy link
Contributor Author

kalgoop commented Oct 28, 2018

Why is build failing?
"let-" works with on my PC (and it actually is right)
CircleCI says "let-" only works with

src/pages/delegates/delegates.html Outdated Show resolved Hide resolved
src/pages/delegates/delegates.html Outdated Show resolved Hide resolved
src/pages/delegates/delegates.html Outdated Show resolved Hide resolved
src/pages/delegates/delegates.html Outdated Show resolved Hide resolved
dated and others added 4 commits October 29, 2018 10:33
Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>
Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>
Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>
Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>
@kalgoop
Copy link
Contributor Author

kalgoop commented Oct 29, 2018

@dated I have seen 'let-' being used with at a dozen of places. Can you please tell why that wasn't working with ?

@dated
Copy link
Contributor

dated commented Oct 29, 2018

hi there! the problem was that the <template> is deprecated in angular 5.

@kalgoop
Copy link
Contributor Author

kalgoop commented Oct 29, 2018

hi there! the problem was that the <template> is deprecated in angular 5.

Oh, thanks. I had Angular 4 installed in my PC.

@luciorubeens luciorubeens merged commit 62163ec into ArkEcosystem:master Oct 30, 2018
@kalgoop kalgoop deleted the patch-1 branch October 30, 2018 16:47
luciorubeens pushed a commit that referenced this pull request Feb 4, 2019
* Bug: Fix delegate search

filterBy pipe of ngx-filter wasn't filtering the list, in the previous version.

Now, used ngFor with ngIf to filter according to searchQuery.username

* Update src/pages/delegates/delegates.html

Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>

* Update src/pages/delegates/delegates.html

Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>

* Update src/pages/delegates/delegates.html

Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>

* Update src/pages/delegates/delegates.html

Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants