This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filterBy pipe of ngx-filter wasn't filtering the list, in the previous version. Now, used ngFor with ngIf to filter according to searchQuery.username
Why is build failing? |
dated
suggested changes
Oct 28, 2018
Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>
Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>
Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>
Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>
@dated I have seen 'let-' being used with at a dozen of places. Can you please tell why that wasn't working with ? |
hi there! the problem was that the |
Oh, thanks. I had Angular 4 installed in my PC. |
luciorubeens
approved these changes
Oct 30, 2018
luciorubeens
pushed a commit
that referenced
this pull request
Feb 4, 2019
* Bug: Fix delegate search filterBy pipe of ngx-filter wasn't filtering the list, in the previous version. Now, used ngFor with ngIf to filter according to searchQuery.username * Update src/pages/delegates/delegates.html Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com> * Update src/pages/delegates/delegates.html Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com> * Update src/pages/delegates/delegates.html Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com> * Update src/pages/delegates/delegates.html Co-Authored-By: kalgoop <17824093+kalgoop@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filterBy pipe of ngx-filter wasn't filtering the list, in the previous version.
Now, used ngFor with ngIf to filter according to searchQuery.username
Proposed changes
Types of changes
Checklist
Further comments