Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade axios #17

Merged
merged 1 commit into from Jun 1, 2019

Conversation

Projects
None yet
4 participants
@dated
Copy link
Contributor

commented May 31, 2019

There is vulnerability on axios <= 0.18: https://nvd.nist.gov/vuln/detail/CVE-2019-10742#vulnCurrentDescriptionTitle

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe: dependencies

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@dated dated requested review from faustbrian and supaiku0 as code owners May 31, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@codecov-io

This comment has been minimized.

Copy link

commented May 31, 2019

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   85.93%   85.93%           
=======================================
  Files           1        1           
  Lines         128      128           
  Branches       21       21           
=======================================
  Hits          110      110           
  Misses         16       16           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f48c4...65107b6. Read the comment docs.

@dated dated changed the title deps: upgrade axios chore(deps): upgrade axios May 31, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit d4e8e6a into ArkEcosystem:master Jun 1, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

Your pull request has been merged and marked as tier 5. It will earn you $5 USD.

@dated dated deleted the dated:deps/axios branch Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.