Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix node/fees query string #58

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@vmunich
Copy link
Member

commented Aug 9, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

Does this PR release a new version?

  • No

Prior to this change:

>>> $c->fees(30)
GuzzleHttp/Exception/ClientException with message 'Client error: `GET https://api.ark.io/api/node/fees?query%5Bdays%5D=20` resulted in a `422 Unprocessable Entity` response:
{"statusCode":422,"error":"Unprocessable Entity","message":"/"query[days]/" is not allowed"}

I'm sending this PR to master because develop is way behind.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 9, 2019

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #58   +/-   ##
=========================================
  Coverage     87.96%   87.96%           
  Complexity       49       49           
=========================================
  Files            10       10           
  Lines           108      108           
=========================================
  Hits             95       95           
  Misses           13       13
Impacted Files Coverage Δ Complexity Δ
src/API/Node.php 100% <100%> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcfc987...4eddc6c. Read the comment docs.

@stale

This comment has been minimized.

Copy link

commented Sep 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale label Sep 8, 2019

@stale stale bot removed the Status: Stale label Sep 9, 2019

@faustbrian faustbrian merged commit bb6e41d into ArkEcosystem:master Sep 9, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/styleci/pr The analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.