Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor to remove warnings #63

Merged
merged 3 commits into from Oct 2, 2019

Conversation

@dated
Copy link
Contributor

commented Oct 2, 2019

Summary

The array_ helper functions have been moved to laravel/helpers.

Gets rid of warnings.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Your pull request has been closed, thank you for trying to solve an issue. If you think it was closed prematurely please provide additional information.

@dated dated reopened this Oct 2, 2019
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

This pull-request has now been re-opened. If applicable please provide additional information as requested by one of the reviewers.

@dated dated changed the title chore: require laravel/helpers and refactor to remove warnings chore: refactor to remove warnings Oct 2, 2019
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian changed the title chore: refactor to remove warnings test: refactor to remove warnings Oct 2, 2019
@faustbrian faustbrian merged commit 7112204 into ArkEcosystem:master Oct 2, 2019
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/styleci/pr The analysis has passed
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@dated dated deleted the dated:chore/unit-tests branch Oct 2, 2019
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Your pull request has been merged. Thank you for your contribution to the ARK Ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.