Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor(profiles): remove extraneous Wallet methods #673

Merged
merged 2 commits into from
Aug 23, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

No description provided.

@faustbrian faustbrian changed the title wip refactor(profiles): remove extraneous Wallet methods Aug 23, 2020
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #673 into master will increase coverage by 15.85%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #673       +/-   ##
===========================================
+ Coverage   49.33%   65.19%   +15.85%     
===========================================
  Files          53       99       +46     
  Lines         748     2011     +1263     
  Branches       83      215      +132     
===========================================
+ Hits          369     1311      +942     
- Misses        365      627      +262     
- Partials       14       73       +59     
Flag Coverage Δ
#unit 65.19% <ø> (+15.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...platform-sdk-profiles/src/wallets/wallet.models.ts 100.00% <ø> (ø)
...ckages/platform-sdk-profiles/src/wallets/wallet.ts 66.87% <ø> (ø)
...latform-sdk-profiles/src/dto/transaction-mapper.ts 43.47% <0.00%> (ø)
...atform-sdk-profiles/src/profiles/profile.models.ts 100.00% <0.00%> (ø)
...ages/platform-sdk-profiles/src/contacts/contact.ts 85.18% <0.00%> (ø)
...profiles/src/wallets/wallet-transaction-service.ts 25.33% <0.00%> (ø)
...ckages/platform-sdk-profiles/src/services/cache.ts 86.95% <0.00%> (ø)
...wallets/aggregates/entity-resignation-aggregate.ts 14.28% <0.00%> (ø)
...allets/aggregates/entity-registration-aggregate.ts 14.28% <0.00%> (ø)
...dk-profiles/src/repositories/setting-repository.ts 95.65% <0.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee97aa...d35829c. Read the comment docs.

@faustbrian faustbrian merged commit ae11ed1 into master Aug 23, 2020
@faustbrian faustbrian deleted the extraneous branch August 23, 2020 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant