New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor #14

Merged
merged 9 commits into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@supaiku0
Collaborator

supaiku0 commented Dec 6, 2018

Proposed changes

Refactors the whole client, bumps dependencies and fixes the ConnectionManager.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@j-a-m-l j-a-m-l self-requested a review Dec 6, 2018

@faustbrian faustbrian requested review from faustbrian and removed request for j-a-m-l Dec 6, 2018

@faustbrian faustbrian referenced this pull request Dec 6, 2018

Closed

chore: upgrade `reqwest` to 0.9.5 #13

3 of 3 tasks complete
@codecov-io

This comment has been minimized.

codecov-io commented Dec 6, 2018

Codecov Report

Merging #14 into master will decrease coverage by 0.49%.
The diff coverage is 90.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #14     +/-   ##
=========================================
- Coverage    93.6%   93.11%   -0.5%     
=========================================
  Files          39       40      +1     
  Lines         813      842     +29     
=========================================
+ Hits          761      784     +23     
- Misses         52       58      +6
Impacted Files Coverage Δ
tests/lib.rs 100% <ø> (ø) ⬆️
tests/connection_test.rs 100% <ø> (ø) ⬆️
src/api/one/one.rs 100% <100%> (ø) ⬆️
tests/api/two/blocks_test.rs 100% <100%> (ø) ⬆️
tests/api/two/votes_test.rs 100% <100%> (ø) ⬆️
tests/api/two/transactions_test.rs 100% <100%> (ø) ⬆️
src/api/two/wallets.rs 92.1% <100%> (+2.81%) ⬆️
tests/api/one/delegates_test.rs 100% <100%> (ø) ⬆️
src/api/two/blocks.rs 83.33% <100%> (+4.76%) ⬆️
src/connection/connection.rs 100% <100%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 239f507...aa6511b. Read the comment docs.

@faustbrian faustbrian merged commit b9b7de3 into ArkEcosystem:master Dec 6, 2018

3 checks passed

ci/circleci: build-beta Your tests passed on CircleCI!
Details
ci/circleci: build-nightly Your tests passed on CircleCI!
Details
ci/circleci: build-stable Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment