Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove version argument remains #42

Merged
merged 4 commits into from Jul 11, 2019

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Contributor

commented Jul 7, 2019

Remove all code that related to setting an API-Version as Core 2.5 will only serve the v2 API.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

The ci/circleci: build-beta job is failing as of 744b06bbe1dd6a1811a99260a2df045613f0a2ba. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

faustbrian and others added some commits Jul 7, 2019

@faustbrian faustbrian merged commit fbe33cb into master Jul 11, 2019

2 checks passed

ci/circleci: build-beta Your tests passed on CircleCI!
Details
ci/circleci: build-stable Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/legacy branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.