Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove version argument remains #35

merged 1 commit into from Jul 11, 2019


None yet
4 participants
Copy link

commented Jul 7, 2019

Remove all code that related to setting an API-Version as Core 2.5 will only serve the v2 API.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

This comment has been minimized.

Copy link

commented Jul 7, 2019

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #35   +/-   ##
  Coverage   97.38%   97.38%           
  Files          19       19           
  Lines         841      841           
  Hits          819      819           
  Misses         22       22
Impacted Files Coverage Δ
Client/Client/Util.swift 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e646fb...8924192. Read the comment docs.


This comment has been minimized.

Copy link

commented Jul 11, 2019

Remove all code

1 line

@ItsANameToo ItsANameToo merged commit b122b0e into master Jul 11, 2019

2 checks passed

ci/circleci: build-and-test Your tests passed on CircleCI!
ci/circleci: swiftlint Your tests passed on CircleCI!

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/legacy branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.