Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing api endpoints #44

Merged
merged 7 commits into from Oct 1, 2019

Conversation

@dated
Copy link
Contributor

commented Sep 13, 2019

Adds the rounds api endpoints.

Adds the transactions/fees endpoint.

Refactors the node/fees function so that it accepts an optional days argument.

@ItsANameToo the project file project.pbxproj needs to be adjusted to include the new files for the Round API.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
dated added 5 commits Sep 9, 2019
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@faustbrian

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

Any more endpoints missing that should be added? So we can wrap them up in a single PR.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

Not that I'm aware of.

dated added 2 commits Sep 30, 2019
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit acf1108 into ArkEcosystem:master Oct 1, 2019
3 checks passed
3 checks passed
build
Details
build
Details
codeclimate Approved by Brian Faust.
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.