Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: simplify pagination #110

Merged
merged 2 commits into from Mar 23, 2020
Merged

Conversation

@Minigugus
Copy link
Contributor

Minigugus commented Mar 22, 2020

Summary

  • Simplify pagination with ApiResponse (therefore fixes rounds)
  • Switch from type to interface for better types preview in code editors

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 22, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

src/interfaces.ts Outdated Show resolved Hide resolved
@faustbrian faustbrian changed the title fix(types): simplify pagination types: simplify pagination Mar 23, 2020
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 23, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 4b1ff6d into ArkEcosystem:master Mar 23, 2020
1 check passed
1 check passed
unit (12.x)
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 23, 2020

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 23, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@boldninja

This comment has been minimized.

Copy link
Member

boldninja commented Apr 1, 2020

@Minigugus Can you provide me with your ARK address so I can send you your bounty reward? You can also contact me on ARK's Slack - https://ark.io/slack (username: Rok [ARK Team]) and direct message me your address there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.