Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use nock & got for http #45

Merged
merged 8 commits into from Jul 4, 2019

Conversation

Projects
None yet
3 participants
@alexbarnsley
Copy link
Member

commented Jul 3, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

The ci/circleci: node-12 job is failing as of dcbb04fb30cde1dae7339ac16ea96d9d8a4daccf. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@alexbarnsley alexbarnsley force-pushed the refactor/nock-got-http branch from dcbb04f to ccd3b9b Jul 4, 2019

@faustbrian faustbrian merged commit b9fb5ff into master Jul 4, 2019

3 checks passed

ci/circleci: node-10 Your tests passed on CircleCI!
Details
ci/circleci: node-11 Your tests passed on CircleCI!
Details
ci/circleci: node-12 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the refactor/nock-got-http branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.