Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force v2 peer endpoint #3

Merged
merged 1 commit into from Jul 5, 2019

Conversation

Projects
None yet
3 participants
@alexbarnsley
Copy link
Member

commented Jul 5, 2019

v2.5 onwards of core defaults /api/... to v2, whereas pre-2.5 defaults to v1. This change forces v2 endpoints regardless of core version.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@faustbrian faustbrian merged commit 04dc0a4 into master Jul 5, 2019

3 checks passed

ci/circleci: node-10 Your tests passed on CircleCI!
Details
ci/circleci: node-11 Your tests passed on CircleCI!
Details
ci/circleci: node-12 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fix/force-v2-peer-endpoint branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.