Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor: merge WalletData and DelegateData #475

Merged
merged 4 commits into from
Jun 23, 2020
Merged

refactor: merge WalletData and DelegateData #475

merged 4 commits into from
Jun 23, 2020

Conversation

faustbrian
Copy link
Contributor

Resolves #473

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #475 into master will increase coverage by 13.44%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #475       +/-   ##
===========================================
+ Coverage   59.41%   72.85%   +13.44%     
===========================================
  Files          35       52       +17     
  Lines         515     1028      +513     
  Branches       43       73       +30     
===========================================
+ Hits          306      749      +443     
- Misses        195      250       +55     
- Partials       14       29       +15     
Flag Coverage Δ
#unit 72.85% <0.00%> (+13.44%) ⬆️
Impacted Files Coverage Δ
packages/platform-sdk-profiles/src/wallet.ts 55.31% <ø> (ø)
...ckages/platform-sdk/src/coins/collections/index.ts 0.00% <ø> (ø)
...ages/platform-sdk/src/coins/collections/wallets.ts 0.00% <0.00%> (ø)
...dk-profiles/src/repositories/profile-repository.ts 88.23% <0.00%> (ø)
packages/platform-sdk-profiles/src/storage/null.ts 100.00% <0.00%> (ø)
packages/platform-sdk-profiles/src/container.ts 80.00% <0.00%> (ø)
...ackages/platform-sdk-profiles/src/wallet.models.ts 100.00% <0.00%> (ø)
...m-sdk-profiles/src/repositories/data-repository.ts 86.36% <0.00%> (ø)
packages/platform-sdk-profiles/src/env.ts 86.04% <0.00%> (ø)
packages/platform-sdk-profiles/src/contact.ts 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec50150...01c7ba7. Read the comment docs.

Brian Faust added 2 commits June 23, 2020 12:21
@faustbrian faustbrian marked this pull request as ready for review June 23, 2020 10:44
@faustbrian faustbrian merged commit 9788bc7 into master Jun 23, 2020
@faustbrian faustbrian deleted the wallet-data branch June 23, 2020 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider merging WalletDTO and DelegateDTO
1 participant