Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Speed up on Node #16
Now we have 3 binaries in npm and script which run necessary binary depends on the current platform.
There are 2 big problems with current behavior:
Hello all, especially @HellSquirrel (as you assigned this task to you),
How do I ask politely if I can offer my help with this task?
I made a prototype of how to download the binary on postinstallI made a crude mockup that downloads the appropriate binary for the current OS (or fail if the OS isn't supported), and afterwards run the `install` command with the downloaded binary. The postinstall script already had a check for CI in place, that can be used to skip the downloading in it's entirety.
I am unsure still how to handle errors on downloading the binary.
But I wanted to ask first, whether this task is still being developed on, and whether I should share my version with somebody.
Edit: Also I don't know where to store the binaries, if not in the
Hi @fleischie ! Thank you for your question and interest in this feature.
I think you don't have to store binaries at all. We can load them from https://github.com/Arkweid/lefthook/releases