Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to force or disable colored output #36

Merged
merged 2 commits into from Aug 1, 2019

Conversation

@orsinium
Copy link
Contributor

commented Jul 31, 2019

  1. Disable colored output if --no-colors flag specified
  2. Force colored output if colors: true specified in the config.
  3. Disable colored output if colors: false specified in the config.
  4. Use old behavior by default: enable colors only for TTY
  5. IsTTY replaced by EnableColors, because now it's about colors, not TTY.

Close #33

Should I update some docs or do some tests? I haven't noticed a good place for it in the current codebase.

Thank you for the nice tool!

@ai

This comment has been minimized.

Copy link
Collaborator

commented Jul 31, 2019

Should we take some checks from the JS library to detect color support? https://github.com/chalk/supports-color/blob/master/index.js

@Arkweid

This comment has been minimized.

Copy link
Owner

commented Aug 1, 2019

Great work @orsinium! Thank you for contribution :)

@Arkweid Arkweid merged commit 1c35728 into Arkweid:master Aug 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@orsinium orsinium deleted the orsinium:colors-flag branch Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.