New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbedtls_hkdf_expand() and mbedtls_hkdf_extract() be not be exposed without a warning #1775

Closed
bmurray7 opened this Issue Jun 22, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@bmurray7
Contributor

bmurray7 commented Jun 22, 2018

The functions mbedtls_hkdf_expand() and mbedtls_hkdf_extract() should not be publicly exposed through the API without a warning that they are, when used individually, not sufficient to provide the same security guarantees as mbedtls_hkdf().

I think it would be best to make mbedtls_hkdf_expand() and mbedtls_hkdf_extract() static and remove them from hkdf.h. If this is not an option, the documentation should be updated to make it more explicit that the extract and expand functions are intermediates and are not intended to be used for key derivation unless the inputs can be shown to satisfy the conditions in Krawczyk.

@RonEld

This comment has been minimized.

Contributor

RonEld commented Jun 24, 2018

@bmurray7 Thank you for reporting this!
We will consider what is the best option to resolve this

@ciarmcom ciarmcom added the mirrored label Jun 24, 2018

@ciarmcom

This comment has been minimized.

Member

ciarmcom commented Jun 24, 2018

ARM Internal Ref: IOTSSL-2373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment