Skip to content
Permalink
Browse files

Fix: qr_OFFSETEWPNCOLLISIONFIX in 2.50.0, and 2.50.1 quests.

Changelog: Re-adjust qr_OFFSETEWPNCOLLISIONFIX in qst.cpp, to force it on for 2.50.0 build < 24,
	instead of build |< 29 (as Gleeok forced it).

	I tested SIX quest files, CREATED in three versions of ZQuest:
		2.50.0, bit set off (b24)
		2.50.0, bit set on (b24)
		2.50.1, bit set off (b28)
		2.50.1, bit set on (b28)
		2.50.2, bit set off (b29)
		2.50.2, bit set on (b29)
	If we check build < 29, then quests made in 2.50.0 and possibly 2.50.1 have
	the bit forced on, when it wasn't intended.

	Unless the actual BEHAVIOUR of this bit has changed (this needs verification),
	then builds 24, 28, 29, 30, 31, and 32 should never force this bit on.

	It is certainly possible that quests made prior to build 24 (2.50.0 release) have this wrong.
	I would need to check every RC to see, and backtrack from there.
  • Loading branch information...
ZoriaRPG
ZoriaRPG committed Feb 16, 2019
1 parent b4f3c97 commit 23e171dae27242e903067dc680d3538a01322f31
Showing with 22 additions and 2 deletions.
  1. +22 −2 src/qst.cpp
@@ -2475,15 +2475,35 @@ int readrules(PACKFILE *f, zquestheader *Header, bool keepdata)
set_bit(quest_rules, qr_OFFSCREENWEAPONS, 1);
}

if(tempheader.zelda_version < 0x250 || (tempheader.zelda_version == 0x250 && tempheader.build<29))
//if(tempheader.zelda_version < 0x250 || (tempheader.zelda_version == 0x250 && tempheader.build<29)) //Gleeok's thing here.
if(tempheader.zelda_version < 0x250 || (tempheader.zelda_version == 0x250 && tempheader.build<24)) //ZoriaRPG, here.
{
// qr_OFFSETEWPNCOLLISIONFIX
// All 'official' quests need this disabled.
// All 2.10 and lower quests need this enabled to preseve compatability.
// All 2.11 - 2.5.1 quests should have it set also, due to a bug in about half of all the betas.



//~Gleeok
set_bit(quest_rules, qr_OFFSETEWPNCOLLISIONFIX, 1); //This has to be set!!!!
/*
I have no clue what Gleeok means here. I tested SIX quest files, CREATED in three versions of ZQuest:
2.50.0, bit set off (b24)
2.50.0, bit set on (b24)
2.50.1, bit set off (b28)
2.50.1, bit set on (b28)
2.50.2, bit set off (b29)
2.50.2, bit set on (b29)
If we check build < 29, then quests made in 2.50.0 and possibly 2.50.1 have
the bit forced on, when it wasn't intended.
Unless the actual BEHAVIOUR of this bit has changed (this needs verification),
then builds 24, 28, 29, 30, 31, and 32 should never force this bit on.
It is certainly possible that quests made prior to build 24 (2.50.0 release) have this wrong.
I would need to check every RC to see, and backtrack from there.
-ZoriaRPG ( 16th February, 2019 )
*/

// Broke in build 695
if(tempheader.zelda_version>=0x211 && tempheader.build>=18)

0 comments on commit 23e171d

Please sign in to comment.
You can’t perform that action at this time.