Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCHPREQUEST/DHCPACK and DHCPREQUEST/DHCPREPLY #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

francois-maillard
Copy link

I added support for the DCHPREQUEST/DHCPACK (IPv4) and DHCPREQUEST/DHCPREPLY (IPv6) flows.

I added support for the DCHPREQUEST/DHCPACK (IPv4) and DHCPREQUEST/DHCPREPLY (IPv6) flows.
@avisnevschi
Copy link

avisnevschi commented Mar 31, 2020

@matejv @ArnesSI @francois-maillard I've just checked, and it seems like ths script is still only generating DHCP Discover, waiting for DHCP Offer, print the result and stops here.
I tried to TCPDUMP all packets on interface, and I see only DHCP Discover / Offer, there is nothing regarding Request / Ack. Even in Debug mode, I don't see anything regarding Request/Ack packets... Trying to modify the code, but can't figure it out..

@avisnevschi
Copy link

@matejv @ArnesSI @francois-maillard
Is there anybody who is still working or watching this project?

@matejv
Copy link
Member

matejv commented Apr 24, 2020

Sorry for no replies, busy with other projects...

I'll take a look at the pull request over the weekend.

@francois-maillard @avisnevschi What are you trying to achieve by going further with the DHCP request flow? Initially I developed this tool to just check if DHCP server responds (and how quickly) to monitor some performance issues we had, so I never felt the need to do anything more than that.

@avisnevschi
Copy link

avisnevschi commented Apr 24, 2020

@matejv Thanks!

I think it is good thing to test all DHCP Server answers, and in generally if the whole processes of obtaining IP via DHCP will be done, then, this tool can be used to test the whole performance of DHCP server, and the fact that it is working correctly. Moreover some DHCP Servers are not adding DHCP lease to database until they get REQUEST and answers with ACK.

So adding REQUEST/ACK to the flow will check the real performance of DHCP server with all the steps involved in this process.

@francois-maillard
Copy link
Author

francois-maillard commented Apr 27, 2020

I'm writing "integration tests" for our hardware installation setup, more precisely writing tests that make sure the dynamic dns updates secured by tsig keys are written to the DNS DB. This only occurs when the lease is actually sent to the client.

@francois-maillard
Copy link
Author

any news on that PR?

@jimsmith
Copy link

jimsmith commented Dec 8, 2021

@matejv @ArnesSI @francois-maillard when will this PR be accepted, as testing DHCP for IPv6 for the REQUEST/ACK is going to help network engineers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants