Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Sites were showing a SSL handshake failure rather then prompting about

the SSL errors.

With the new NetworkAccessManagerProxy the signals were being sent to
the proxy and not the primary networkaccessmanager.

Issue: 666
  • Loading branch information...
commit 461e5adcaddca251fdbb79e3734372c4cdf947a9 1 parent e4f3a8d
@icefox icefox authored
Showing with 11 additions and 0 deletions.
  1. +11 −0 src/utils/networkaccessmanagerproxy.cpp
View
11 src/utils/networkaccessmanagerproxy.cpp
@@ -58,6 +58,17 @@ void NetworkAccessManagerProxy::setPrimaryNetworkAccessManager(NetworkAccessMana
setCookieJar(m_primaryManager->cookieJar());
// Do not steal ownership!
cookieJar()->setParent(manager);
+
+ connect(this, SIGNAL(authenticationRequired(QNetworkReply*, QAuthenticator*)),
+ m_primaryManager, SIGNAL(authenticationRequired(QNetworkReply*, QAuthenticator*)));
+ connect(this, SIGNAL(finished(QNetworkReply *)),
+ m_primaryManager, SIGNAL(finished(QNetworkReply *)));
+ connect(this, SIGNAL(proxyAuthenticationRequired(const QNetworkProxy&, QAuthenticator*)),
+ m_primaryManager, SIGNAL(proxyAuthenticationRequired(const QNetworkProxy&, QAuthenticator*)));
+#ifndef QT_NO_OPENSSL
+ connect(this, SIGNAL(sslErrors(QNetworkReply*, const QList<QSslError>&)),
+ m_primaryManager, SIGNAL(sslErrors(QNetworkReply*, const QList<QSslError>&)));
+#endif
}
QNetworkReply *NetworkAccessManagerProxy::createRequest(QNetworkAccessManager::Operation op, const QNetworkRequest &request, QIODevice *outgoingData)
Please sign in to comment.
Something went wrong with that request. Please try again.