Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Sites were showing a SSL handshake failure rather then prompting about

the SSL errors.

With the new NetworkAccessManagerProxy the signals were being sent to
the proxy and not the primary networkaccessmanager.

Issue: 666
  • Loading branch information...
commit 461e5adcaddca251fdbb79e3734372c4cdf947a9 1 parent e4f3a8d
Benjamin C Meyer authored October 02, 2009

Showing 1 changed file with 11 additions and 0 deletions. Show diff stats Hide diff stats

  1. 11  src/utils/networkaccessmanagerproxy.cpp
11  src/utils/networkaccessmanagerproxy.cpp
@@ -58,6 +58,17 @@ void NetworkAccessManagerProxy::setPrimaryNetworkAccessManager(NetworkAccessMana
58 58
     setCookieJar(m_primaryManager->cookieJar());
59 59
     // Do not steal ownership!
60 60
     cookieJar()->setParent(manager);
  61
+
  62
+    connect(this, SIGNAL(authenticationRequired(QNetworkReply*, QAuthenticator*)),
  63
+            m_primaryManager, SIGNAL(authenticationRequired(QNetworkReply*, QAuthenticator*)));
  64
+    connect(this, SIGNAL(finished(QNetworkReply *)),
  65
+            m_primaryManager, SIGNAL(finished(QNetworkReply *)));
  66
+    connect(this, SIGNAL(proxyAuthenticationRequired(const QNetworkProxy&, QAuthenticator*)),
  67
+            m_primaryManager, SIGNAL(proxyAuthenticationRequired(const QNetworkProxy&, QAuthenticator*)));
  68
+#ifndef QT_NO_OPENSSL
  69
+    connect(this, SIGNAL(sslErrors(QNetworkReply*, const QList<QSslError>&)),
  70
+            m_primaryManager, SIGNAL(sslErrors(QNetworkReply*, const QList<QSslError>&)));
  71
+#endif
61 72
 }
62 73
 
63 74
 QNetworkReply *NetworkAccessManagerProxy::createRequest(QNetworkAccessManager::Operation op, const QNetworkRequest &request, QIODevice *outgoingData)

0 notes on commit 461e5ad

Please sign in to comment.
Something went wrong with that request. Please try again.