This repository has been archived by the owner on Nov 22, 2020. It is now read-only.
Singleton and Localization #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t without having to modify the repo. This is important to support using Harpy as a submodule.
…s and which action was taken
|
Added localizations for:
|
|
Thanks! I'll get to it as soon as I can! Been a busy couple weeks. |
|
I'm looking into this right now. Finally found time :) Looks great thus far! |
This was referenced Apr 7, 2013
Closed
|
Hey David, I went through this in a lot of detail. I loved 99.9% of your changes. I am therefore going to merge your pull request into the Master repo, and then overwrite it with one or two minor changes and an expanded README. All of this should be done in the next 30 mins or so. |
ArtSabintsev
added a commit
that referenced
this pull request
Apr 7, 2013
v2.3.0 - Added Singleton and Localization. Big thanks to David Keegan (@kgn on Github)
|
Well done! Thanks @ArtSabintsev & @kgn |
|
@alexruperez it was all @kgn incorporating everyone's ideas, plus some of this own. Thank you both for stepping up! |
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great project!
I've made a couple changes that I hope you'll like.
The first main change is I made Harpy a singleton with a
sharedInstancemethod. This allows theappIDandalertTypeto be set without having to modify the constants header. In-fact I removed this header file completely. The reason for this is that having to modify files in the repo make it difficult to use git submodules. This should fix #18.The second change moves the strings into a localizable file. This also fixes #16 but in a slightly different way.