setImageUri takes too long #3

Closed
gmarques33 opened this Issue Mar 25, 2015 · 7 comments

Projects

None yet

3 participants

@gmarques33

When I get a photo from G+ Photos app, sometimes this need to be downloaded. In this case the app will hang for some time and I get an ANR.

With older devices, decodeBitmat takes too long too.

I think that setImageUri needs to be executed on a background thread. The method setImageUri can accept a callback and return after the job has done.

@sethgho
sethgho commented May 6, 2015

This seems like a problem worth solving. @ArthurHub, what do you think the right answer should be here? Disabling the crop support and drawing some sort of loading indicator on the crop image view while downloading the Bitmap?

@ArthurHub
Owner

Yep, that sounds reasonable, maybe provide the client with optional widget to be placed while it is loading.

@sethgho
sethgho commented May 11, 2015

Hmm... how about an async overload of setImageUri with just a basic success/failure callback? That should let the client toggle whatever UI state they want.

@gmarques33

@sethgho That's exactly what I did.
I will improve the code and make a pull request.

@sethgho
sethgho commented May 11, 2015

👍

@ArthurHub
Owner

👍

@ArthurHub ArthurHub self-assigned this Dec 19, 2015
@ArthurHub
Owner

added setImageUriAsync(Uri) and getCroppedImageAsync() in v1.1.0

@ArthurHub ArthurHub closed this Dec 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment