Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://issues.jboss.org/browse/SRAMP-513 #452

Closed
wants to merge 1 commit into from

Conversation

@dvirgiln
Copy link
Contributor

dvirgiln commented Jul 14, 2014

@brmeyer brmeyer changed the title https://issues.jboss.org/browse/DTGOV-173 https://issues.jboss.org/browse/SRAMP-513 Jul 18, 2014
@@ -564,11 +564,11 @@ private ArtifactType getArtifactType(MavenGavInfo gavInfo, String artifactModel)
return ArtifactType.valueOf("MavenPom"); //$NON-NLS-1$
} else if (isPrimaryArtifact(gavInfo) && customAT != null) {
return ArtifactType.valueOf(customAT);
}
if (artifactModel!=null) {

This comment has been minimized.

Copy link
@brmeyer

brmeyer Jul 18, 2014

Contributor

Maybe I'm misunderstanding, but shouldn't this block be kept? It would look like:

        if (gavInfo.getType().equals("jar")) {
            return ArtifactType.valueOf("ext", "JavaArchive", true); //$NON-NLS-1$
        } else if (artifactModel!=null) {
            return ArtifactType.valueOf("ext", artifactModel, true); //$NON-NLS-1$
        } else {
            return ArtifactType.valueOf(ArtifactTypeEnum.Document.name());
        }
return ArtifactType.valueOf("ext", artifactModel, true); //$NON-NLS-1$
}
if (gavInfo.getType().equals("jar")) {
return ArtifactType.valueOf("ext", "JavaArchive", true); //$NON-NLS-1$

This comment has been minimized.

Copy link
@brmeyer

brmeyer Jul 18, 2014

Contributor

Add a comment here to describe why we're explicitly checking "jar"? "// Necessary for -source jars", something like that

@brmeyer

This comment has been minimized.

Copy link
Contributor

brmeyer commented Jul 21, 2014

Looks like @EricWittmann already changed this during DTGOV-127

@brmeyer brmeyer closed this Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.